Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow k8ssandra.io labels and annotations in services config (fixes #689) #690

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

olim7t
Copy link
Contributor

@olim7t olim7t commented Aug 23, 2024

What this PR does:

Which issue(s) this PR fixes:
Fixes #689

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@olim7t olim7t requested a review from a team as a code owner August 23, 2024 23:12
@olim7t olim7t changed the title Allow some internal labels and annotaions in services config (fixes #689) Allow some internal labels and annotations in services config (fixes #689) Aug 23, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@olim7t olim7t changed the title Allow some internal labels and annotations in services config (fixes #689) Allow k8ssandra.io labels and annotations in services config (fixes #689) Aug 26, 2024
Copy link
Contributor

@burmanm burmanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs rebase for changelog

@olim7t olim7t merged commit af6648a into k8ssandra:master Aug 27, 2024
42 checks passed
@olim7t olim7t deleted the svc-labels branch August 27, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit label and annotation restrictions in AdditionalServiceConfig
2 participants